Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): double panic if broken state in block builder #17091

Merged
merged 5 commits into from
Dec 20, 2024
Merged

fix(query): double panic if broken state in block builder #17091

merged 5 commits into from
Dec 20, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Dec 20, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix(query): double panic if broken state in block builder

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - cannot mock broken state

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 20, 2024
@zhang2014 zhang2014 closed this Dec 20, 2024
@zhang2014 zhang2014 reopened this Dec 20, 2024
@zhang2014 zhang2014 changed the title fix(query): fix call double finish in transform accumulating fix(query): double panic if broken state in block builder Dec 20, 2024
@zhang2014 zhang2014 requested a review from youngsofun December 20, 2024 07:03
@zhang2014 zhang2014 enabled auto-merge December 20, 2024 07:08
@zhang2014 zhang2014 added this pull request to the merge queue Dec 20, 2024
Merged via the queue into databendlabs:main with commit f7a4a5d Dec 20, 2024
72 of 73 checks passed
@zhang2014 zhang2014 deleted the fix/double_drop branch December 20, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@youngsofun youngsofun Awaiting requested review from youngsofun

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhang2014 @sundy-li